-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otel: simple OTEL collector/Jaeger/Aspire stack for testing purposes #47733
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Christopher Petito <47751006+krissetto@users.noreply.github.com>
aspire-dashboard: | ||
image: mcr.microsoft.com/dotnet/nightly/aspire-dashboard | ||
ports: | ||
- 18888:18888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if we should use 127.0.0.1
for these; just in case someone runs this without considering that mapping the port will default to the public interface. @akerouanton any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's generally better to bind 127.0.0.1
to not expose services needlessly on the LAN. But personnally, I'm using this stack to have a single collector on my home network and send Engine traces from all my machines to it. I'm okay binding these to 0.0.0.0
and let contributors figure out what's the most appropriate for their situation.
|
||
## How can I use it? | ||
|
||
1) Export the env var used to override the OTLP endpoint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit; should this be a actual markdown numbered list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh good question, I thought it looked a bit better but I guess it depends on the markdown renderer used. No hard feelings here, if it's "more correct" to do otherwise i'll change this
- What I did
Added a compose stack to be used for testing out OTEL functionality
- How I did it
- How to verify it
Read the doc and try it out :)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)